Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add blinding factors to the quotient polynomial #778

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Add blinding factors to the quotient polynomial #778

merged 2 commits into from
Oct 18, 2023

Conversation

xevisalle
Copy link
Member

This PR fixes a vulnerability found in Plonk, as described here:

https://x.com/rel_zeta_tech/status/1542474186664210432?s=20

@xevisalle xevisalle added fix:vulnerability Issues related to fix vulnerabilities of the architecture or software before-mainnet Issues that need to be tackled before mainnet. labels Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023 •
edited
Loading

Codecov Report

Merging #778 (4a4cc7a) into master (29c9500) will decrease coverage by 0.94%.
The diff coverage is 27.69%.

❗ Current head 4a4cc7a differs from pull request most recent head 7a05730. Consider uploading reports for the commit 7a05730 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #778      +/-   ##
==========================================
- Coverage   84.96%   84.02%   -0.94%     
==========================================
  Files          57       57              
  Lines        4037     4094      +57     
==========================================
+ Hits         3430     3440      +10     
- Misses        607      654      +47
Files Coverage Δ
src/composer/prover.rs 95.54% <100.00%> (+0.20%) ⬆️
tests/logic.rs 67.92% <2.08%> (-28.48%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29c9500...7a05730. Read the comment docs.

autholykos
autholykos reviewed Oct 17, 2023
View reviewed changes
tests/logic.rs Outdated Show resolved Hide resolved
moCello
moCello requested changes Oct 18, 2023
View reviewed changes
Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some clippy nits and a plea to better isolate the failing test which might hint to a bug

src/composer/prover.rs Outdated Show resolved Hide resolved
src/composer/prover.rs Outdated Show resolved Hide resolved
src/composer/prover.rs Outdated Show resolved Hide resolved
tests/logic.rs Show resolved Hide resolved
@xevisalle xevisalle requested a review from moCello October 18, 2023 10:01
@xevisalle xevisalle force-pushed the add_more_blinding_factors branch from 0247560 to b70e144 Compare October 18, 2023 10:55
@xevisalle xevisalle linked an issue Oct 18, 2023 that may be closed by this pull request
Check the zero-knowledge property of PlonK #773
Closed
@xevisalle xevisalle merged commit 8f9cf5a into master Oct 18, 2023
5 checks passed
@xevisalle xevisalle deleted the add_more_blinding_factors branch October 18, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@autholykos autholykos autholykos left review comments

@marta-belles marta-belles marta-belles approved these changes

@moCello moCello moCello approved these changes

@vlopes11 vlopes11 Awaiting requested review from vlopes11

@javiersilva0 javiersilva0 Awaiting requested review from javiersilva0

Assignees
No one assigned
Labels
before-mainnet Issues that need to be tackled before mainnet. fix:vulnerability Issues related to fix vulnerabilities of the architecture or software
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check the zero-knowledge property of PlonK
4 participants
@xevisalle @autholykos @moCello @marta-belles